Skip to content

Conversation

@AdrianCert
Copy link
Contributor

@AdrianCert AdrianCert commented Jan 27, 2025

Running tox -c pyproject.toml with content not ini legacy end up with a failure: could not recognize config file pyproject.toml

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No pull request is ready to be reviewed without test attacher.

@AdrianCert
Copy link
Contributor Author

AdrianCert commented Jan 27, 2025

On #3117 was mentioned this issue where i come up with this hotfix

When you run tox .. it's ok but tox -c pyproject.toml will try to open with legacy approach and exit synce will try only the 1st one

@gaborbernat
Copy link
Member

I understand that but you still need to add the test that really the change fixes the issue.

Running tox -c pyproject.toml with content not ini legacy end up with a failure:
could not recognize config file pyproject.toml

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci
@gaborbernat gaborbernat merged commit 8d302eb into tox-dev:main Jan 28, 2025
28 checks passed
@gaborbernat
Copy link
Member

Fix released with https://github.com/tox-dev/tox/releases/tag/4.24.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants